Make raise_for_status chainable
#2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
force-pushed
the
raise_for_status-chain
branch
from
a2f8dbe
to
00c6795
Compare
tomchristie
changed the title
raise_for_status chainableraise_for_status chainable
abersheeran
approved these changes
Jul 31, 2023
|
Okay great, so...
|
|
I think this usage should be mentioned in the docstring and prose documentation. |
|
Really nice DX improvement here, I see myself using this a lot! |
|
document updated |
tomchristie
requested changes
Aug 1, 2023
Co-authored-by: Tom Christie <[email protected]>
Co-authored-by: Tom Christie <[email protected]>
Co-authored-by: Tom Christie <[email protected]>
tomchristie
approved these changes
Aug 1, 2023
|
is there any ETA on next release? |
|
If you're up for helping drive a release pull request, then we could fix up a minor point release whenever really. |
Can we include encode/httpcore#745 in the next httpx release? First, we should release httpcore with that pull request and then release httpx |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
make it possible to write code like
r = httpx.get('...').raise_for_status().json()Refs #2775
Checklist